[Edge] Cancel the timer from running when we are done with it #2807
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
force-pushed
the
edge-fix
branch
from
df4427f to
7625606
Compare
Contributor
Contributor
Author
|
@HeikoKlare I don't know how to automate a regression test for this, I assume the existing test cases will cover it sufficiently. |
HeikoKlare
reviewed
Nov 24, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for the catch, @jonahgraham!
The change sounds totally reasonable to me. I agree that we probably don't need an additional regression test for this. Still, what about just adding a test that basically consists of your snippet from #2806 followed by a control creation to ensure that no "no more handles" error occurs?
I.e., something like:
for (int i = 0; i < 20000; i++) {
browser.setText("Iteration " + i);
new BrowserFunction(browser, "name");
}
new Composite(shell, SWT.NONE);
jonahgraham
force-pushed
the
edge-fix
branch
from
7625606 to
a1fa734
Compare
Contributor
Author
Done. |
Each use of a timer creates a User Object in Windows, and once we have stopped waiting for our desired event we don't need the cancellation tracking anymore. If there are lots of calls to processOSMessagesUntil, such as repeated browser.setText within the MAXIMUM_OPERATION_TIME (5 second) window, we can end up with a huge growth in the number of User Objects, leading to potential `SWTError: No more handles` errors elsewhere in the client code. Fixes eclipse-platform#2806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each use of a timer creates a User Object in Windows, and once we have stopped waiting for our desired event we don't need the cancellation tracking anymore.
If there are lots of calls to processOSMessagesUntil, such as repeated browser.setText within the MAXIMUM_OPERATION_TIME (5 second) window, we can end up with a huge growth in the number of User Objects, leading to potential
SWTError: No more handleserrors elsewhere in the client code.Fixes #2806